Bug 6488 - spec file does not manage mariadb/mysql dependency for building accounting_storage_mysql.so
Summary: spec file does not manage mariadb/mysql dependency for building accounting_st...
Status: OPEN
Alias: None
Product: Slurm
Classification: Unclassified
Component: Build System and Packaging (show other bugs)
Version: 18.08.4
Hardware: Linux Linux
: --- 5 - Enhancement
Assignee: Unassigned Developer
QA Contact:
URL:
: 8882 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-02-12 08:22 MST by Regine Gaudin
Modified: 2021-05-17 11:41 MDT (History)
5 users (show)

See Also:
Site: CEA
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed: 18.08.6, 19.05
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---

Attachments
build log (56.14 KB, application/x-bzip)
2019-09-20 14:00 MDT, Kilian Cavalotti 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Regine Gaudin 2019-02-12 08:22:07 MST 
Package mariadb-devel is not required but its missing leads to failure of the rpmbuild (18.08.04 but also all 17.11.06)

[root@vm0 SPECS]# yum-builddep slurm.spec
Loaded plugins: priorities
694 packages excluded due to repository priority protections
Getting requirements for slurm.spec
 --> Already installed : systemd-219-30.el7_3.9.x86_64
 --> Already installed : munge-devel-0.5.11-3.el7.x86_64
 --> Already installed : munge-libs-0.5.11-3.el7.x86_64
 --> Already installed : python-2.7.5-48.el7.x86_64
 --> Already installed : readline-devel-6.2-9.el7.x86_64
 --> Already installed : 1:openssl-devel-1.0.1e-60.el7_3.1.x86_64
 --> Already installed : 1:openssl-1.0.1e-60.el7_3.1.x86_64
 --> Already installed : perl-ExtUtils-MakeMaker-6.68-3.el7.noarch
 --> Already installed : pam-devel-1.1.8-18.el7.x86_64
No uninstalled build requires

[root@vm0 SPECS]# rpm -qa|grep mariadb
[root@vm0 SPECS]#

[root@vm0 SPECS]#rpmbuild -ba slurm.spec
...
Processing files: slurm-slurmdbd-18.08.4-1.el7.x86_64
error: File not found: /root/rpmbuild/BUILDROOT/slurm-18.08.4-1.el7x86_64/usr/lib64/slurm/accounting_storage_mysql.so
RPM build errors:
    File not found: /root/rpmbuild/BUILDROOT/slurm-18.08.4-1.el7.x86_64/usr/lib64/slurm/accounting_storage_mysql.so
    File not found: /root/rpmbuild/BUILDROOT/slurm-18.08.4-1.el7.x86_64/usr/lib64/slurm/accounting_storage_mysql.so

After installation of  mariadb-devel build is ok
[root@vm0 SPECS]# rpm -qa|grep -i mariadb
mariadb-devel-5.5.52-1.el7.x86_64
mariadb-libs-5.5.52-1.el7.x86_64

Checking for unpackaged file(s): /usr/lib/rpm/check-files /root/rpmbuild/BUILDROOT/slurm-18.08.4-1.el7.x86_64
Wrote: /root/rpmbuild/SRPMS/slurm-18.08.4-1.el7.src.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-18.08.4-1el7.x86_64.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-perlapi-18.08.4-1.el7.x86_64.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-devel-18.08.4-1.el7.x86_64.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-example-configs-18.08.4-1.el7.86_64.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-slurmctld-18.08.4-1.el7.x86_64.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-slurmd-18.08.4-1.el7.x86_64.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-slurmdbd-18.08.4-1.el7.x86_64.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-libpmi-18.08.4-1.el7.x86_64.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-torque-18.08.4-1.el7.x86_64.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-openlava-18.08.4-1.l7.x86_64.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-contribs-18.08.4-1.el7.x86_64.rpm
Wrote: /root/rpmbuild/RPMS/x86_64/slurm-pam_slurm-18.08.4-1.el7.x86_64.rpm
Comment 1 Nate Rini 2019-02-12 15:06:56 MST 
Confirmed your error. Looking at how best to fix it now.
Comment 3 Nate Rini 2019-02-12 15:35:56 MST 
Created attachment 9146 [details]
patch
Comment 8 Nate Rini 2019-02-13 11:34:38 MST 
Gaudin,

The issue has been fixed by this patch for 18.08.6:
https://github.com/SchedMD/slurm/commit/d18e26b9719e06a

Please reply to reopen this ticket if you have any issues or questions.

Thanks,
--Nate
Comment 10 Nate Rini 2019-03-07 16:13:48 MST 
Gaudin,

The fix was included with 18.08.6, and was removed from 18.08.6-2. Other sites found that the behavior change caused issues and we will reconsider the change for future releases.

Thanks,
--Nate
Comment 11 Regine Gaudin 2019-03-13 04:42:33 MDT 
We are currently forcing the use of mysql/mariadb-devel adding
buildrequires in slurm.spec:

# Build with mysql by default on linux
%bcond_without mysql

%if %{with mysql}
BuildRequires: mysql-devel >= 5.0.0
%endif


yum provides mysql-devel is pointing on mariadb-devel package 

Regine
Comment 15 Kilian Cavalotti 2019-09-20 10:17:13 MDT 
Hi there, 

It looks like this issue is still present in 19.05.2.

Is there an issue with adding "BuildRequires: mysql-devel" when mysql support is activated, as Regine proposed in #c11? That looks like a good solution to me.

Cheers,
-- 
Kilian
Comment 16 Nate Rini 2019-09-20 12:01:30 MDT 
(In reply to Kilian Cavalotti from comment #15)
> It looks like this issue is still present in 19.05.2.
> 
> Is there an issue with adding "BuildRequires: mysql-devel" when mysql
> support is activated, as Regine proposed in #c11? That looks like a good
> solution to me.
The patch was reverted for 19.05.2 to avoid other build issues. Can you please attach your build log?
Comment 17 Kilian Cavalotti 2019-09-20 14:00:08 MDT 
Created attachment 11648 [details]
build log

Hi Nate, 

Just to clarify, I'm referring to the suggestion of adding this to the spec file:
-- 8< ----------------------------------
# Build with mysql by default on linux
%bcond_without mysql

%if %{with mysql}
BuildRequires: mysql-devel >= 5.0.0
%endif
-- 8< ----------------------------------
not to the patch from https://github.com/SchedMD/slurm/commit/d18e26b9719e06a


The build log is attached.

Thanks!
-- 
Kilian
Comment 19 Nate Rini 2019-09-24 14:24:50 MDT 
(In reply to Kilian Cavalotti from comment #17)
> Just to clarify, I'm referring to the suggestion of adding this to the spec
> not to the patch from https://github.com/SchedMD/slurm/commit/d18e26b9719e06a

Killian,

We are discussing internally how best to proceed with fixing the rpm spec files.

Thanks,
--Nate
Comment 21 Nate Rini 2020-04-20 09:15:01 MDT 
*** Bug 8882 has been marked as a duplicate of this bug. ***
Comment 23 Tim Wickberg 2021-05-17 11:41:10 MDT 
*** Bug 11631 has been marked as a duplicate of this bug. ***