Ticket 10737 - Contribution: access --network from job_submit/lua
Summary: Contribution: access --network from job_submit/lua
Status: RESOLVED FIXED
Alias: None
Product: Slurm
Classification: Unclassified
Component: Other (show other tickets)
Version: 20.11.3
Hardware: Linux Linux
: --- C - Contributions
Assignee: Tim Wickberg
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2021-01-29 09:36 MST by Luke Yeager
Modified: 2021-02-05 12:36 MST (History)
2 users (show)

See Also:
Site: NVIDIA (PSLA)
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed: 20.11.4
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---

Attachments
[PATCH] job_submit/lua - add network field (1.60 KB, patch)
2021-01-29 09:39 MST, Luke Yeager 		Details | Diff
[PATCH] job_submit/lua - add network field (v2) (1.14 KB, patch)
2021-02-05 09:54 MST, Luke Yeager 		Details | Diff
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this ticket.
Description Luke Yeager 2021-01-29 09:36:41 MST 
At our site, we would like to be able to access the value given for --network at job submission from the job_submit/lua plugin.

1. We don't like that invalid --network values are ignored, and we would like to explicitly reject jobs with bogus flags like '--network=foo'.

2. We would like to be able to restrict access to network plugins by filtering by account.
Comment 1 Luke Yeager 2021-01-29 09:39:53 MST 
Created attachment 17673 [details]
[PATCH] job_submit/lua - add network field
Comment 2 Tim Wickberg 2021-01-29 14:52:19 MST 
I have no problem with the additional field, but I'm a bit concerned about throwing NVIDIA copyright blocks into files with trivial changes. Is there a strong reason NVIDIA needs these added in?
Comment 3 Luke Yeager 2021-02-01 09:27:18 MST 
I'll get back to you on that.
Comment 4 Luke Yeager 2021-02-05 09:54:15 MST 
Created attachment 17790 [details]
[PATCH] job_submit/lua - add network field (v2)

I finally got my questions resolved. I've re-attached the patch after removing the needless copyright header.
Comment 5 Tim Wickberg 2021-02-05 12:35:29 MST 
Comment on attachment 17790 [details]
[PATCH] job_submit/lua - add network field (v2)

commit f8a65bea7005f2c2a34328c49256ec43324e869d
Author:     Luke Yeager <lyeager@nvidia.com>
AuthorDate: Fri Feb 5 08:51:42 2021 -0800

    job_submit/lua - add network field
    
    Allows job_submit/lua to access the --network field used for job
    submission. This can be used to conditionally reject jobs with an
    invalid (network, account) combination, for example.
    
    Bug 10737
Comment 6 Tim Wickberg 2021-02-05 12:36:44 MST 
Thanks Luke. In ahead of 20.11.4.