Ticket 2243 - Lua not properly configured when detected
Summary: Lua not properly configured when detected
Status: RESOLVED FIXED
Alias: None
Product: Slurm
Classification: Unclassified
Component: Configuration (show other tickets)
Version: 15.08.5
Hardware: Linux Linux
: --- 3 - Medium Impact
Assignee: Tim Wickberg
QA Contact:
URL:
: 2246 2253 2264 (view as ticket list)
Depends on:
Blocks:
 
Reported: 2015-12-10 11:52 MST by Chris Samuel
Modified: 2015-12-15 15:40 MST (History)
5 users (show)

See Also:
Site: VLSCI
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed: 15.08.6 16.05.0-pre1
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---


Attachments
replacement xlua.c (2.73 KB, text/plain)
2015-12-15 01:01 MST, Tim Wickberg
Details

Note You need to log in before you can comment on or make changes to this ticket.
Description Chris Samuel 2015-12-10 11:52:24 MST
With 15.08.5 (not an option to pick yet) the configuration system doesn't correctly handle lua.

[2015-12-11T12:38:38.890] slurmctld version 15.08.5 started on cluster snowy
[2015-12-11T12:38:38.891] error: xlua_dlopen: Not compiled with lua support!  Please install a lua dev package.
[2015-12-11T12:38:38.891] error: Couldn't load specified plugin name for job_submit/lua: Plugin init() callback failed
[2015-12-11T12:38:38.891] error: cannot create job_submit context for job_submit/lua
[2015-12-11T12:38:38.891] fatal: failed to initialize job_submit plugin


The output of configure says:

[root@snowy-m SLURM]# fgrep -w lua config-15.08.5.out
checking for lua... yes
checking for whether we can link to liblua... yes lua
config.status: creating contribs/lua/Makefile
config.status: creating src/plugins/job_submit/lua/Makefile
config.status: creating src/plugins/proctrack/lua/Makefile


But HAVE_LUA_5_1 never gets set in config.h.

Setting it & recompiling fixes the issue.
Comment 1 Tim Wickberg 2015-12-10 12:03:53 MST
Version corrected, sorry about that.

What OS are you running? I'm thinking that the autotools macro isn't detecting the -dev version properly, leaving you with the inconsistent build.
Comment 2 Chris Samuel 2015-12-10 12:08:00 MST
(In reply to Tim Wickberg from comment #1)

> Version corrected, sorry about that.
> 
> What OS are you running? I'm thinking that the autotools macro isn't
> detecting the -dev version properly, leaving you with the inconsistent build.

This is RHEL 6.7.
Comment 3 Tim Wickberg 2015-12-11 05:25:29 MST
*** Ticket 2246 has been marked as a duplicate of this ticket. ***
Comment 4 Alan Pfeiffer-Traum 2015-12-14 06:16:58 MST
I saw the same behavior in RHEL6.6.

My workaround was to create a symlink from the existing file lua.pc to lua5.1.pc in /usr/lib64/pkgconfig - just for the duration of the build.

The new configure script wants pkg-config to find either lua5.1 or lua5.2.
Comment 5 Alejandro Sanchez 2015-12-14 19:28:22 MST
*** Ticket 2253 has been marked as a duplicate of this ticket. ***
Comment 6 Tim Wickberg 2015-12-15 01:01:16 MST
Created attachment 2508 [details]
replacement xlua.c

replacement xlua.c restoring old behavior
Comment 7 Tim Wickberg 2015-12-15 01:06:32 MST
Hey folks -

I've attached a replacement for src/common/xlua.c that restores the expected behavior from the rest of the 15.08 series - something similar will be included in the next 15.08 point release.

My apologies for the bug - what was meant as a minor fix to avoid problems with mismatched Lua headers and library versions (bug 2131) has obviously backfired. Any further work on this will move to 16.05 to avoid any further problems, this really shouldn't have been done in 15.08.

- Tim
Comment 8 David Matthews 2015-12-15 01:23:35 MST
Tim
Are you planning to fix the underlying problem in the "configure" script? This still contains flawed logic, see Bug 2246. The same code is present in 14.11.6 - it just doesn't cause any problem with the build.
Thanks,
Dave
Comment 9 Tim Wickberg 2015-12-15 01:33:38 MST
(In reply to David Matthews from comment #8)
> Tim
> Are you planning to fix the underlying problem in the "configure" script?
> This still contains flawed logic, see Bug 2246. The same code is present in
> 14.11.6 - it just doesn't cause any problem with the build.
> Thanks,
> Dave

Yes, but not in 15.08.

With 16.05, I'll be reworking the autoconf macros to handle this in a way that's not dependent on exact package naming schemes which vary considerably between the RPM and DEB distros.
Comment 10 Tim Wickberg 2015-12-15 03:44:35 MST
Commit 1536deab has the fix applied, and will be in the next 15.08.6 release.

Further work for 16.05 will be done under bug 2131.

- Tim
Comment 11 Tim Wickberg 2015-12-15 15:40:03 MST
*** Ticket 2264 has been marked as a duplicate of this ticket. ***