Ticket 2264 - recent changes to lua detection do not work in SLES (thus Cray)
Summary: recent changes to lua detection do not work in SLES (thus Cray)
Status: RESOLVED DUPLICATE of ticket 2243
Alias: None
Product: Slurm
Classification: Unclassified
Component: slurmctld (show other tickets)
Version: 15.08.5
Hardware: Cray XC Linux
: --- 3 - Medium Impact
Assignee: Tim Wickberg
QA Contact:
URL:
Depends on:
Blocks:
 
Reported: 2015-12-15 11:12 MST by Doug Jacobsen
Modified: 2015-12-15 15:40 MST (History)
0 users

See Also:
Site: NERSC
Alineos Sites: ---
Atos/Eviden Sites: ---
Confidential Site: ---
Coreweave sites: ---
Cray Sites: ---
DS9 clusters: ---
HPCnow Sites: ---
HPE Sites: ---
IBM Sites: ---
NOAA SIte: ---
OCF Sites: ---
Recursion Pharma Sites: ---
SFW Sites: ---
SNIC sites: ---
Linux Distro: ---
Machine Name:
CLE Version:
Version Fixed:
Target Release: ---
DevPrio: ---
Emory-Cloud Sites: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this ticket.
Description Doug Jacobsen 2015-12-15 11:12:43 MST 
Hello,

I tried to build slurm 15.08.5 today but the initial attempts failed owing to slurmctld crashing when trying to load liblua and then refusing to.

It seems that the code was changed to rely more on pkg-config, and in particular on the existence of the pkg: "lua5.1" or "lua5.2".  On a SLES system the pc file is named "lua.pc" thus the package is lua.

The logic in auxdir/x_ac_lua.m4 won't set either of the cpp variables needed to load liblua now.

I tried a number of variations of the x_ac_lua.m4, but after deciding that my brain was mush today, I simply symlinked both lua.pc to lua5.1.pc and the library to liblua5.1.so.0

I would like to remove both of these as soon as possible and rebuild with proper detection of the lua library.

Thanks so much, and I do appreciate that this move is more in the direction of portability than the old code, but this initial effort seems to be missing a few cases.  I might recommend detecting the library path in configure and setting that as the dlopen target, instead of hardwiring particular strings in the new xlua common code.

-Doug
Comment 1 Tim Wickberg 2015-12-15 11:16:45 MST 
On my phone at the moment so please excuse my brevity - this is bug #2243, and we have a patch to revert this committed already.

My apology for the problem. As you noticed this was meant as a way to handle this better in the long run but has definitely backfired.

- Tim

On December 15, 2015 8:12:43 PM EST, bugs@schedmd.com wrote:
>http://bugs.schedmd.com/show_bug.cgi?id=2264
>
>           Site: NERSC - National Energy Research Supercomputing Center
>            Bug ID: 2264
>           Summary: recent changes to lua detection do not work in SLES
>                    (thus Cray)
>           Product: Slurm
>           Version: 15.08.5
>          Hardware: Cray XC
>                OS: Linux
>            Status: UNCONFIRMED
>          Severity: 3 - Medium Impact
>          Priority: ---
>         Component: slurmctld
>          Assignee: support@schedmd.com
>          Reporter: dmjacobsen@lbl.gov
>
>Hello,
>
>I tried to build slurm 15.08.5 today but the initial attempts failed
>owing to
>slurmctld crashing when trying to load liblua and then refusing to.
>
>It seems that the code was changed to rely more on pkg-config, and in
>particular on the existence of the pkg: "lua5.1" or "lua5.2".  On a
>SLES system
>the pc file is named "lua.pc" thus the package is lua.
>
>The logic in auxdir/x_ac_lua.m4 won't set either of the cpp variables
>needed to
>load liblua now.
>
>I tried a number of variations of the x_ac_lua.m4, but after deciding
>that my
>brain was mush today, I simply symlinked both lua.pc to lua5.1.pc and
>the
>library to liblua5.1.so.0
>
>I would like to remove both of these as soon as possible and rebuild
>with
>proper detection of the lua library.
>
>Thanks so much, and I do appreciate that this move is more in the
>direction of
>portability than the old code, but this initial effort seems to be
>missing a
>few cases.  I might recommend detecting the library path in configure
>and
>setting that as the dlopen target, instead of hardwiring particular
>strings in
>the new xlua common code.
>
>-Doug
>
>-- 
>You are receiving this mail because:
>You are the assignee for the bug.
Comment 2 Tim Wickberg 2015-12-15 15:40:03 MST 
Marking as duplicate of bug 2243 which has been patched for the future 15.08.6 release.

*** This ticket has been marked as a duplicate of ticket 2243 ***